Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CSTM-CPC-976)Add a pet to an Owner #527

Merged
merged 9 commits into from
Oct 9, 2023
Merged

feat(CSTM-CPC-976)Add a pet to an Owner #527

merged 9 commits into from
Oct 9, 2023

Conversation

Nmazza1
Copy link
Collaborator

@Nmazza1 Nmazza1 commented Oct 6, 2023

JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-967?atlOrigin=eyJpIjoiNWY5MjJiN2IxYWU4NDkyOTgxZDEwZjVlMmQwNjkwMWMiLCJwIjoiaiJ9

Context:

Add Pet to owner functionality did not exist.

Changes

Added / Updated the functionality for adding pets to add a pet and retrieve them based off their OwnerId

Before and After UI (Required for UI-impacting PRs)

New Page:
addpet

Dev notes (Optional)

Yippee!!!!

@github-actions
Copy link

github-actions bot commented Oct 9, 2023 •
edited
Loading

Qodana for JVM

329 new problems were found

Inspection name Severity Problems
Redundant character escape 🔶 Warning 85
Unused import 🔶 Warning 70
Dangling Javadoc comment 🔶 Warning 16
Invalid YAML configuration 🔶 Warning 11
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 9
Default annotation parameter value 🔶 Warning 5
Lombok annotations 🔶 Warning 5
Optional.get() is called without isPresent() check 🔶 Warning 5
AutoCloseable used without 'try'-with-resources 🔶 Warning 4
Deprecated API usage 🔶 Warning 4
Link specified as plain text 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 4
Redundant local variable 🔶 Warning 4
Unused assignment 🔶 Warning 4
Possibly blocking call in non-blocking context 🔶 Warning 3
Nullability and data flow problems 🔶 Warning 3
Field can be local 🔶 Warning 3
Spring Data repository method parameters errors 🔶 Warning 3
'Optional' used as field or parameter type 🔶 Warning 2
Unused publisher 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Field may be 'final' 🔶 Warning 1
Lombok @Getter may be used 🔶 Warning 1
Mismatch in @PathVariable declarations and usages 🔶 Warning 1
Begin or end anchor in unexpected position 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Call to 'printStackTrace()' 🔶 Warning 1
Unnecessary call to 'toString()' 🔶 Warning 1
Commented out code ◽️ Notice 37
Non recommended 'field' injections ◽️ Notice 18
Duplicated code fragment ◽️ Notice 13
Constant values ◽️ Notice 3
Mismatch in @PathVariable declarations and usages ◽️ Notice 1
Throw statement in Reactive operator ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Saimirz
Saimirz approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@Saimirz Saimirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be okay. This is definitely a functionality we needed for this veterinarian system.

DisgruntledMensch
DisgruntledMensch approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@DisgruntledMensch DisgruntledMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick, lemme know if this also fixes the persistency issues we were having.

@Nmazza1 Nmazza1 merged commit b8497d5 into main Oct 9, 2023
3 checks passed
@Nmazza1 Nmazza1 deleted the feat/CSTM-CPC-967/Add-Pet-to-Owner-Functionality branch October 9, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saimirz Saimirz Saimirz approved these changes

@DisgruntledMensch DisgruntledMensch DisgruntledMensch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nmazza1 @DisgruntledMensch @Saimirz